Improve LS APIs to support tuple type mappings by pasindufernando1 · Pull Request #653 · ballerina-platform/ballerina-language-server

pasindufernando1 · 2026-01-22T05:51:50Z

Purpose

Addresses : wso2/product-ballerina-integrator#2304

Copilot

Pull request overview

This pull request improves the Language Server APIs to support tuple type mappings in data mapper functionality. The changes enable proper handling of tuple types in mapping operations, including generation of tuple member names, proper indexing with bracket notation, and correct default value generation for tuple elements.

Changes:

Enhanced tuple type name generation to display types in the format [type1, type2, ...]
Modified data mapping logic to distinguish between tuples (bracket notation) and arrays (dot notation)
Added comprehensive test coverage for tuple-based mappings and transformations

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
misc/diagram-util/src/test/resources/RefTypeTest/BalProject7/main.bal	Adds test case for record with tuple field
misc/diagram-util/src/test/java/org/ballerinalang/diagramutil/RefTypeTest.java	Uncomments updateConfig call to automatically update test expectations
misc/diagram-util/src/main/java/org/ballerinalang/diagramutil/connector/models/connector/ReferenceType.java	Implements tuple type name generation with proper member type names
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/delete_mapping/source/tupleMember.bal	Adds test source for tuple member deletion
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/delete_mapping/config/tupleMember.json	Test configuration for tuple member deletion
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/data_mapper_source/source/tupleTransformation.bal	Test source for tuple transformation with function return type
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/data_mapper_source/source/tupleMapping.bal	Test source for tuple field mapping in records
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/data_mapper_source/config/*.json	Test configurations for tuple mapping scenarios
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/data_mapper_model/source/*.bal	Test sources for tuple-based data mapper model generation
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/resources/data_mapper_model/config/*.json	Test configurations for tuple model generation
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/java/io/ballerina/flowmodelgenerator/extension/DataMappingSourceTest.java	Registers new tuple mapping test cases
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/java/io/ballerina/flowmodelgenerator/extension/DataMappingModelTest.java	Registers new tuple model test cases
flow-model-generator/modules/flow-model-generator-ls-extension/src/test/java/io/ballerina/flowmodelgenerator/extension/DataMappingDeleteTest.java	Registers tuple member deletion test case
flow-model-generator/modules/flow-model-generator-ls-extension/src/main/java/io/ballerina/flowmodelgenerator/extension/DataMapperService.java	Passes semantic model to data mapper for type resolution
flow-model-generator/modules/flow-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/DataMapManager.java	Core implementation of tuple type handling, including bracket notation for tuple indexing, default value generation, and proper member type tracking

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/DataMapManager.java

misc/diagram-util/src/test/java/org/ballerinalang/diagramutil/RefTypeTest.java

...il/src/main/java/org/ballerinalang/diagramutil/connector/models/connector/ReferenceType.java

...extension/src/test/java/io/ballerina/flowmodelgenerator/extension/DataMappingDeleteTest.java

...flow-model-generator-ls-extension/src/test/resources/data_mapper_model/source/variable50.bal

...-extension/src/test/java/io/ballerina/flowmodelgenerator/extension/DataMappingModelTest.java

...-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/DataMapManager.java

LakshanWeerasinghe · 2026-01-23T06:31:16Z

@pasindufernando1 can you add a screen recording on how we handle tuples in the data mapper?

LakshanWeerasinghe · 2026-01-23T06:32:55Z

Did we consider the cases of filler value concept in tuples? I am not sure about the use cases in data mapper.
@gimantha

function transform() returns [string, int] => [];

pasindufernando1 · 2026-01-23T06:41:29Z

Did we consider the cases of filler value concept in tuples? I am not sure about the use cases in data mapper. @gimantha
function transform() returns [string, int] => [];

Yes this case is also handled

...s/flow-model-generator-ls-extension/src/test/resources/delete_mapping/source/tupleMember.bal

...flow-model-generator-ls-extension/src/test/resources/data_mapper_model/source/variable50.bal

...w-model-generator-ls-extension/src/test/resources/data_mapper_source/source/tupleMapping.bal

pasindufernando1 · 2026-01-23T07:06:21Z

@pasindufernando1 can you add a screen recording on how we handle tuples in the data mapper?

Added to the issue : wso2/product-ballerina-integrator#2304 (comment)

gimantha · 2026-01-23T07:40:08Z

Did we consider the cases of filler value concept in tuples? I am not sure about the use cases in data mapper. @gimantha
function transform() returns [string, int] => [];

Filler value concept shoud be considered in case if a pro-code user wants to view it in datamapper. Filler values should be shown as default values in datamapper output. It not low-coder user might see it as not mapped.

...extension/src/test/java/io/ballerina/flowmodelgenerator/extension/DataMappingSourceTest.java

KavinduZoysa · 2026-02-03T05:49:01Z

@pasindufernando1, let's add a test to the nested tuple.

...-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/DataMapManager.java

...extension/src/test/java/io/ballerina/flowmodelgenerator/extension/DataMappingDeleteTest.java

...-extension/src/test/java/io/ballerina/flowmodelgenerator/extension/DataMappingModelTest.java

...extension/src/test/java/io/ballerina/flowmodelgenerator/extension/DataMappingSourceTest.java

KavinduZoysa · 2026-02-03T09:20:31Z

...-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/DataMapManager.java

        for (int i = 0; i < size; i++) {
            List<Mapping> elements = new ArrayList<>();
            Node expr = expressions.get(i);
+            String elementPath = isTuple ? name + "[" + i + "]" : name + "." + i;


As I understood, we don't have to handle the notation of a tuple separately.

Since this is a list costructor we can do it in the same way as an array.
@pasindufernando1, can you check the approach again?

pasindufernando1 requested a review from KavinduZoysa as a code owner January 22, 2026 05:51

Copilot AI review requested due to automatic review settings January 22, 2026 05:51

pasindufernando1 marked this pull request as draft January 22, 2026 05:52

Copilot started reviewing on behalf of pasindufernando1 January 22, 2026 05:52 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

pasindufernando1 force-pushed the TupleBEChanges branch from d3660d5 to 1a2e9d1 Compare January 22, 2026 09:41

pasindufernando1 marked this pull request as ready for review January 22, 2026 09:46

gimantha reviewed Jan 23, 2026

View reviewed changes

...s/flow-model-generator-ls-extension/src/test/resources/delete_mapping/source/tupleMember.bal Outdated Show resolved Hide resolved

gimantha reviewed Jan 23, 2026

View reviewed changes

...flow-model-generator-ls-extension/src/test/resources/data_mapper_model/source/variable50.bal Outdated Show resolved Hide resolved

gimantha reviewed Jan 23, 2026

View reviewed changes

...w-model-generator-ls-extension/src/test/resources/data_mapper_source/source/tupleMapping.bal Outdated Show resolved Hide resolved

pasindufernando1 added 12 commits January 23, 2026 12:38

Refactor tuple member related info

1d3fdf2

Handle tuple inputs in mappings

7fd16c3

Improve APIs to support inline tuples mappings

006f2e1

Support tuple mappings and visualization in reusable mode

cf9ddb7

Support tuple member mapping deletion in reusable data mapper

1aec4a0

Remove module info data from tuple members

d605bd5

Resolve checkstyle violation

416f2f4

Address PR suggestions

e1a76a9

Fix tuple mapping inconsistencies in queries

08dac6c

Fix failing test case

6b5ef46

Remove element access index from tuple mappings

501c05c

Add newline at EOF

85acd4a

pasindufernando1 force-pushed the TupleBEChanges branch from 1dd3a22 to 85acd4a Compare January 23, 2026 07:08

KavinduZoysa requested a review from gimantha February 3, 2026 04:57